-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Added support for multi-project GKE Hub registration #840
feat!: Added support for multi-project GKE Hub registration #840
Conversation
Added an optional variable HUB_PROJECT_ID which will allow you to specific a seperate GCP project for the GKE HUB than the project the cluster is deployed to. This included updating the 3 examples the leveraged the hub module. Issue: #837
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @JamesDuncanNz
Ensuring that the Hub default Service Account exists when adding a cluster from outside the hub project Issue: #837
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
@JamesDuncanNz can you test an upgrade from previous hub version to this. There maybe a delete recreate op as we are changing create_cmd_gke_body
and would be good to capture this in the upgrade guide as it may result in the de registration and subsequent registration during upgrade.
…m-google-modules#840) * Added support for multi-project GKE Hub registration Added an optional variable HUB_PROJECT_ID which will allow you to specific a seperate GCP project for the GKE HUB than the project the cluster is deployed to. This included updating the 3 examples the leveraged the hub module. Issue: terraform-google-modules#837 * Adding service idenity resource for multi project deployments Ensuring that the Hub default Service Account exists when adding a cluster from outside the hub project Issue: terraform-google-modules#837 * Fixing bharathkkb comments Fixes terraform-google-modules#837 * Fix linting issue * Removed Google project data souce Issue: terraform-google-modules#837 * Adding upgrade documentation for this change. * Lint updates on readme. Co-authored-by: James Duncan <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Added an optional variable HUB_PROJECT_ID which will allow you to specific a seperate
GCP project for the GKE HUB than the project the cluster is deployed to.
This included updating the 3 examples the leveraged the hub module.
Fixes #837