Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: dynamic operator yaml #693

Merged
merged 6 commits into from
Jan 12, 2021
Merged

feat!: dynamic operator yaml #693

merged 6 commits into from
Jan 12, 2021

Conversation

bharathkkb
Copy link
Member

Creating a local file operator_cr.yaml in an ephemeral pipeline during create results in an error during subsequent destroy if that file is not present.

This PR aims to pass the rendered yaml via stdin.

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners October 2, 2020 03:54
@comment-bot-dev
Copy link

comment-bot-dev commented Oct 2, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member Author

@cloud-pharaoh Could you test with this branch?

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jan 5, 2021
@bharathkkb bharathkkb removed the Stale label Jan 11, 2021
@bharathkkb bharathkkb requested a review from morgante January 11, 2021 21:36
@bharathkkb bharathkkb changed the title [WIP] feat: dynamic operator yaml feat: dynamic operator yaml Jan 11, 2021
@bharathkkb bharathkkb changed the title feat: dynamic operator yaml feat!: dynamic operator yaml Jan 11, 2021
@bharathkkb
Copy link
Member Author

Breaking change as this will delete and recreate operator

@morgante
Copy link
Contributor

@bharathkkb Please make sure to update the upgrade guide with a note about the new change.

@bharathkkb bharathkkb merged commit b1cce30 into master Jan 12, 2021
@bharathkkb bharathkkb deleted the dynamic-acm-operator branch January 12, 2021 04:08
@release-please release-please bot mentioned this pull request Jan 12, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* feat: dynamic operator yaml

* typo

* add ACM submodule to upgrade guide

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants