refactor!:remove hub from asm module #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-pharaoh
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
bharathkkb
requested changes
Sep 10, 2020
There was a problem hiding this comment.
Thanks for the PR @cloud-pharaoh
We have this example which is actually an integration test. To keep those passing, I propose we invoke the hub module within that same example.
Another alternative is to use a new test just for hub but I dont think thats necessary as we should be consolidating wherever possible.
bharathkkb
changed the title
|
w00t! |
|
@cloud-pharaoh one minor nit. The documentation for |
|
Good catch. I totally forgot there were words in there apart from the variables and outputs :) |
bharathkkb
added a commit
that referenced
this pull request
Sep 15, 2020
BREAKING CHANGE: GKE Hub functionality has been removed from ASM module(#665). Users can leverage Hub module for this functionality.
bharathkkb
added a commit
that referenced
this pull request
Sep 15, 2020
BREAKING CHANGE: GKE Hub functionality has been removed from ASM module(#665). Users can leverage Hub module for this functionality.
Merged
This was referenced Sep 15, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
* remove hub from asm module * fix test * Change membership name to expected name * clean up README.md
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
BREAKING CHANGE: GKE Hub functionality has been removed from ASM module(terraform-google-modules#665). Users can leverage Hub module for this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #661