Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'grant_registry_access' variable to add 'storage.objectViewer'-role to SA #236

Conversation

paulpalamarchuk
Copy link
Contributor

@paulpalamarchuk paulpalamarchuk commented Aug 16, 2019

@paulpalamarchuk paulpalamarchuk force-pushed the add_storage_viewer_role_to_sa branch from 4163eff to 7f8fa9e Compare August 16, 2019 08:29
@paulpalamarchuk paulpalamarchuk changed the title Fixes #229 Add sa_grant_gcs_access variable to add storage.objectViewer-role to SA Aug 16, 2019
@kopachevsky
Copy link
Contributor

kopachevsky commented Aug 16, 2019

@morgante @aaron-lane can you cleanup CI server please

Error installing provider "google": write /tmp/getter323505370/archive: no space left on device.

@paulpalamarchuk paulpalamarchuk force-pushed the add_storage_viewer_role_to_sa branch from 7f8fa9e to c24149e Compare August 16, 2019 09:14
CHANGELOG.md Outdated Show resolved Hide resolved
@paulpalamarchuk paulpalamarchuk force-pushed the add_storage_viewer_role_to_sa branch from c24149e to d893d5c Compare August 16, 2019 10:00
ingwarr
ingwarr previously approved these changes Aug 16, 2019
@morgante
Copy link
Contributor

@paulpalamarchuk Let's call the variable grant_registry_access.

@paulpalamarchuk paulpalamarchuk force-pushed the add_storage_viewer_role_to_sa branch from d893d5c to 8ceea77 Compare August 16, 2019 17:24
@paulpalamarchuk paulpalamarchuk changed the title Add sa_grant_gcs_access variable to add storage.objectViewer-role to SA Add 'grant_registry_access' variable to add 'storage.objectViewer'-role to SA Aug 16, 2019
@paulpalamarchuk
Copy link
Contributor Author

@paulpalamarchuk Let's call the variable grant_registry_access.

@morgante Variable name updated.

ingwarr
ingwarr previously approved these changes Aug 16, 2019
kopachevsky
kopachevsky previously approved these changes Aug 19, 2019
ingwarr
ingwarr previously approved these changes Aug 20, 2019
@paulpalamarchuk paulpalamarchuk marked this pull request as ready for review August 20, 2019 12:18
 * Added `grant_registry_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
@paulpalamarchuk paulpalamarchuk dismissed stale reviews from ingwarr and kopachevsky via 31cb015 August 20, 2019 12:32
@paulpalamarchuk paulpalamarchuk force-pushed the add_storage_viewer_role_to_sa branch from b2081e1 to 31cb015 Compare August 20, 2019 12:32
ingwarr
ingwarr previously approved these changes Aug 20, 2019
morgante
morgante previously approved these changes Aug 22, 2019
@morgante morgante dismissed stale reviews from ingwarr and themself via 7f9559c August 22, 2019 00:47
@morgante morgante merged commit 0fca886 into terraform-google-modules:master Aug 22, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…add_storage_viewer_role_to_sa

Add 'grant_registry_access' variable to add 'storage.objectViewer'-role to SA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grant storage viewer to created service accounts
4 participants