feat!: add boot_disk_kms_key variable for node pools to GA modules #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1c0x
changed the title
|
@bharathkkb @Jberlinsky Would you mind taking a look? Thanks. |
bharathkkb
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Thanks for the PR @r1c0x
Since we are moving this out of beta we should also bump the min supported provider. Looking at the change log this looks like it was added in 4.31.0.
bharathkkb
changed the title
…tribute is moving out of beta
|
Thanks @bharathkkb for the review. The provider version is sorted. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
@r1c0x |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…erraform-google-modules#1371) * Add boot_disk_kms_key variable for node pools * Update README.md for boot_disk_kms_key variable * Bump min supported version of the provider since boot_disk_kms_key attribute is moving out of beta * re run build * loose match test Co-authored-by: Andrew Peabody <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for boot_disk_kms_key for node pools that allows encrypting boot disks with customer-managed encryption keys.
https://cloud.google.com/kubernetes-engine/docs/how-to/using-cmek
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#boot_disk_kms_key