Allow enabling managed Prometheus in beta cluster submodules #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@jroiseux |
ykzts
reviewed
Jun 25, 2022
Comment on lines
+97
to
+103
| dynamic "managed_prometheus" { | ||
| for_each = var.monitoring_enable_managed_prometheus ? [1] : [] | ||
|
|
||
| content { | ||
| enabled = var.monitoring_enable_managed_prometheus | ||
| } | ||
| } |
There was a problem hiding this comment.
You can also enable managed_prometheus if autopilot_cluster is true (but Autopilot cannot enable enable_components).
There was a problem hiding this comment.
@ykzts Can you open an issue so we can track this for autopilot support?
bharathkkb
approved these changes
Jun 27, 2022
|
any plans to release this feature? |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…erraform-google-modules#1307) * add ability to enable managed prometheus in beta cluster * check if enable managed prometheus is set * set enabled_components to null if not specified Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed Prometheus can now be enabled with the release of the beta provider,
4.25.0.Adds an input,
monitoring_enable_managed_prometheus, to beta cluster submodules using a nested dynamic block in the pre-existingmonitoring_configblock.The
monitoring_configblock previously only accepted themonitoring_enabled_componentsinput, which is now set to null if it is not specified, in order to preventSYSTEM_COMPONENTSfrom being disabled whenmonitoring_enable_managed_prometheusis set to true.Fixes PR #1298
Resolves #1290 and #1167