BREAKING CHANGE: support maintenance_exclusion #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyz
force-pushed
the
feature/maintenance-exclusion
branch
12 times, most recently
from
5bdd99f to
7e22154
Compare
|
Breaking Change:
|
|
@bharathkkb @Jberlinsky - please review and there will be breaking change on this PR. |
apeabody
changed the title
bharathkkb
reviewed
Jun 1, 2022
There was a problem hiding this comment.
Thanks for the PR @ericyz
Looks like this will need a rebase
cluster.tf
Outdated
| start_time = maintenance_exclusion.value.start_time | ||
| end_time = maintenance_exclusion.value.end_time | ||
|
|
||
| exclusion_options { |
There was a problem hiding this comment.
Lets make this a dynamic block created iff maintenance_exclusion.value.exclusion_options is set.
bharathkkb
reviewed
Jun 3, 2022
cluster.tf
Outdated
| @@ -133,21 +135,25 @@ resource "google_container_cluster" "primary" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "daily_maintenance_window" { | |||
There was a problem hiding this comment.
Shouldn't this still be a dynamic block?
There was a problem hiding this comment.
Yes, let me updated that
ericyz
force-pushed
the
feature/maintenance-exclusion
branch
2 times, most recently
from
5507045 to
f2ae5d7
Compare
|
Please review @bharathkkb @Jberlinsky |
ericyz
force-pushed
the
feature/maintenance-exclusion
branch
3 times, most recently
from
6b2dd8d to
b52ac6a
Compare
bharathkkb
approved these changes
Jun 7, 2022
ericyz
changed the title
|
@bharathkkb - any ETA when the next major version release? |
|
@ericyz we can do the next release as major version. Could you rebase this and I can merge. |
|
Rebased |
ericyz
force-pushed
the
feature/maintenance-exclusion
branch
from
1c76e79 to
a4526b3
Compare
ericyz
force-pushed
the
feature/maintenance-exclusion
branch
from
a4526b3 to
2657270
Compare
|
@ericyz |
bharathkkb
approved these changes
Jun 24, 2022
This was referenced Jun 24, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.