Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch region for gpu quota #1138

Merged
merged 2 commits into from
Jan 31, 2022
Merged

chore: switch region for gpu quota #1138

merged 2 commits into from
Jan 31, 2022

Conversation

bharathkkb
Copy link
Member

tests seem to be failing due to a quota issue for GPUs

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners January 31, 2022 18:09
@comment-bot-dev
Copy link

comment-bot-dev commented Jan 31, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@g-awmalik
Copy link
Contributor

Can this be done in a vars files specific to this fixture instead of hardcoding in the fixture itself?

@bharathkkb
Copy link
Member Author

@g-awmalik We generally prefer to hardcode as much as possible rather than having var files

Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit 073f1fe into master Jan 31, 2022
@bharathkkb bharathkkb deleted the fix-test-gpu-quota branch January 31, 2022 19:40
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* chore: switch region for gpu quota

* fix test to interpolate location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants