Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spot vm support to beta clusters #1131

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Add spot vm support to beta clusters #1131

merged 6 commits into from
Jan 26, 2022

Conversation

adrianchifor
Copy link
Contributor

Fixes #1127

@adrianchifor adrianchifor mentioned this pull request Jan 21, 2022
Closed
@comment-bot-dev
Copy link

comment-bot-dev commented Jan 21, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb requested changes Jan 24, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianchifor Could you rebase on main? It would be great to get this for our breaking release.

@domino7
Copy link

domino7 commented Jan 25, 2022

Hi @bharathkkb, @adrianchifor, I was working on the same, waiting with PR for recent providers updates. I opened #1133 rebased on main just in case @adrianchifor will be not able to move forward with this before next release cycle

@adrianchifor
Copy link
Contributor Author

Thanks @domino7 but I've just rebased and updated.

cc @bharathkkb

@adrianchifor
Copy link
Contributor Author

@bharathkkb Any chance we can merge this? Would like to try out the new release tomorrow on a few node pools.

bharathkkb
bharathkkb approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also mention the min beta provider required in this upgrade guide: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v18.0.md?

@adrianchifor
Copy link
Contributor Author

Noted 4.3+ on google-beta.

@bharathkkb bharathkkb merged commit ae0d953 into terraform-google-modules:master Jan 26, 2022
@release-please release-please bot mentioned this pull request Jan 26, 2022
Merged
@adrianchifor adrianchifor deleted the add_spot_beta branch January 28, 2022 17:35
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@adrianchifor
feat!: Add spot vm support to beta clusters (terraform-google-modules…
5d71d09 
…#1131)

* Add spot vm support to beta clusters

* Update autogen, make build

* Pin min beta version

* Make build

* Update min test beta version

* Note on v18 upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Spot instances in node pools?
4 participants
@adrianchifor @comment-bot-dev @domino7 @bharathkkb