Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow datapath_provider in GA main module #1084

Conversation

somethingnew2-0
Copy link
Contributor

First time contributor implementing #1074

Had to bump the main module GA google provider to 3.55.0 to enable datapath_provider being GA https://github.com/hashicorp/terraform-provider-google/blob/e2e533f83c388fecbf51ae8ca541326b152cede0/CHANGELOG.md#3550-february-1-2021

@comment-bot-dev
Copy link

comment-bot-dev commented Dec 6, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @somethingnew2-0
Looks like we will also need to bump

@alexandruivan
Copy link

Hello. Is anyone looking to finish this work or I can pick it up and finish it?

@somethingnew2-0 somethingnew2-0 force-pushed the datapath_provider-main-ga branch from b43d1be to 847a214 Compare January 13, 2022 16:20
@somethingnew2-0
Copy link
Contributor Author

@bharathkkb @alexandruivan rebased and fixed the version issue

@morgante morgante merged commit 3b5ddb9 into terraform-google-modules:master Jan 13, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…ules#1084)

* Allow datapath_provider in GA main module

* Update examples and tests to 3.55.0

* Update remaining version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants