Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networks and Subnetworks are updated everytime #75

Closed
lantier opened this issue Jan 29, 2019 · 3 comments
Closed

Networks and Subnetworks are updated everytime #75

lantier opened this issue Jan 29, 2019 · 3 comments
Labels
blocked-0.12 bug Something isn't working

Comments

@lantier
Copy link
Contributor

lantier commented Jan 29, 2019

Everytime the module is executed, it try to change the network and subnetworks internal links. Effectively this causes nothing, but the internal Google Api only writes the pattern: projects/project-id/global/networks/network-name

~ module.kubernetes.google_container_cluster.primary
      network:    "projects/my-project/global/networks/my-network" => "https://www.googleapis.com/compute/v1/projects/my-project/global/networks/my-network"
      subnetwork: "projects/my-project/regions/southamerica-east1/subnetworks/my-subnet" => "https://www.googleapis.com/compute/v1/projects/my-project/regions/southamerica-east1/subnetworks/my-subnet"

I believe this commit may be the cause. This change was made by some issue? I couldn't find a related one

@morgante
Copy link
Contributor

This was a workaround for an upstream issue. You should probably open a new upstream issue because either subnet format (full URI or just postfix) is meant to be acceptable.

@aaron-lane
Copy link
Contributor

The workaround should be removed when this module implements support for Terraform v0.12.

@aaron-lane aaron-lane added the bug Something isn't working label May 6, 2019
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 13, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 13, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 13, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 13, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 13, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 13, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
bohdanyurov-gl pushed a commit to bohdanyurov-gl/terraform-google-kubernetes-engine that referenced this issue Jun 18, 2019
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
aaron-lane pushed a commit that referenced this issue Jul 9, 2019
#158
#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
@aaron-lane
Copy link
Contributor

@lantier can you please confirm that the 4.0.0 release of this module fixes your issue?

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
terraform-google-modules#158
terraform-google-modules#75

Add support for TF 0.12.
- autogen
- root and private_cluster modules
- tests (including support for validation)
- examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-0.12 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants