Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to include example of setting service account #39

Closed
coryodaniel opened this issue Dec 13, 2018 · 2 comments
Closed

Update examples to include example of setting service account #39

coryodaniel opened this issue Dec 13, 2018 · 2 comments

Comments

@coryodaniel
Copy link
Contributor

I was setting up a cluster with this module using the examples as a reference and kept running into issues about the service account not existing (I set up the project with the project factory).

As noted in the README1 the node pools should specify the service account. I got tripped up on this since it wasn't in the examples.

It could be helpful to add a note in the examples or in the examples' README.

Looks like issue #23 would also resolve this.

Footnotes:

  1. pardon the blame view, needed to link to the line in the readme
@morgante
Copy link
Contributor

I think we should address this via #2 and simply always require that a Service Account be either created or passed in.

Relying on the default service account is brittle and unstable.

@aaron-lane
Copy link
Contributor

Fixed by #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants