Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cluster service account to be overridden without specifying in var.node_pools #23

Closed
Jberlinsky opened this issue Oct 25, 2018 · 2 comments
Closed

Allow cluster service account to be overridden without specifying in var.node_pools #23

Jberlinsky opened this issue Oct 25, 2018 · 2 comments
Assignees
@Jberlinsky

Comments

@Jberlinsky
Copy link
Contributor

Jberlinsky commented Oct 25, 2018 •
edited
Loading

When a service project is created with terraform-google-project-factory, it does not have a default compute instance, which breaks the default usage thereof. Specifying it as part of var.node_pools does not work in all circumstances, as the tags & taints do not get read in properly.
@Jberlinsky Jberlinsky self-assigned this Oct 25, 2018
@Jberlinsky Jberlinsky mentioned this issue Oct 25, 2018
Merged
@Jberlinsky Jberlinsky changed the title Enable Shared VPCs in Separate Regions and/or Projects Enable Shared VPCs when created by project-factory Oct 25, 2018
@morgante
Copy link
Contributor

#2 is related.

@Jberlinsky Jberlinsky changed the title Enable Shared VPCs when created by project-factory Allow cluster service account to be overridden without specifying in var.node_pools Oct 25, 2018
@coryodaniel coryodaniel mentioned this issue Dec 13, 2018
Closed
@Jberlinsky Jberlinsky mentioned this issue Dec 13, 2018
Merged
@aaron-lane
Copy link
Contributor

Fixed by #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jberlinsky Jberlinsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jberlinsky @morgante @aaron-lane