Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting node locations on individual node pools #290

Closed
morgante opened this issue Oct 21, 2019 · 6 comments · Fixed by #303
Closed

Allow setting node locations on individual node pools #290

morgante opened this issue Oct 21, 2019 · 6 comments · Fixed by #303
Assignees
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@morgante
Copy link
Contributor

morgante commented Oct 21, 2019

As added upstream, we need to update this module to support specifying node_locations on individual node pools (that potentially differ from the cluster's overall locations).

This will unblock #263.

@morgante morgante added the enhancement New feature or request label Oct 21, 2019
@morgante morgante added the triaged Scoped and ready for work label Oct 24, 2019
@bharathkkb
Copy link
Member

@morgante I can pick this up next if no one else has started

@morgante
Copy link
Contributor Author

@bharathkkb Go ahead, thanks!

@bharathkkb
Copy link
Member

@morgante quick question about this. I was trying to implement it like below but seems like I cant have arrays and strings within a single map.

node_pools = [
   {
      name               = "my-node-pool"
      node_locations     = ["us-west1-a", "us-west1-c"]
      .....
    }]

For taints, tags etc which requires lists we have used a different variable. Should I use that approach here?

node_pools = [
    {
      name               = "my-node-pool"
      .....
    }]
  node_pools_locations={
      my-node-pool = ["us-west1-a", "us-west1-c"]
    }

@morgante
Copy link
Contributor Author

I'd suggest we simply comma-separate the locations in a string, as the simplest approach.

@bharathkkb
Copy link
Member

Yes that makes sense. Thanks

@aaron-lane
Copy link
Contributor

By the by, I've opened #306 to address the limitation of node_pools using maps rather than objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants