-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: promote gke_backup_agent_config to ga #1513
feat!: promote gke_backup_agent_config to ga #1513
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@Jberlinsky Can you please help me understand test failure. |
Error Trace: /workspace/test/integration/private_zonal_with_networking/golden.go:158 |
You might want to update the https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/integration/private_zonal_with_networking/testdata/TestPrivateZonalWithNetworking.json to include the new attribute. |
0194fca
to
b12983f
Compare
@ericyz can you help with test failure once again? Thank you! |
Hi @Tolsee - It looks to be an ordering issue in: https://github.com/Tolsee/terraform-google-kubernetes-engine/blob/feature/promote-gke_backup_agent_config-to-ga/test/integration/private_zonal_with_networking/testdata/TestPrivateZonalWithNetworking.json#L8 Looks like you need to move
|
0411716
to
b2eb34f
Compare
@apeabody It still failing 🤦🏼. Also, I am unable to run tests locally, so can you help me once more. Thank you. |
test/integration/private_zonal_with_networking/testdata/TestPrivateZonalWithNetworking.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update as Andrew' commented. LGTM for other code
b2eb34f
to
b788a19
Compare
b788a19
to
055adbf
Compare
@Tolsee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #1450