Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest network_policy be enabled by default #138

Closed
bgeesaman opened this issue Apr 17, 2019 · 3 comments · Fixed by #356
Closed

Suggest network_policy be enabled by default #138

bgeesaman opened this issue Apr 17, 2019 · 3 comments · Fixed by #356
Assignees
@bharathkkb
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@bgeesaman
Copy link

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/variables.tf#L106

Suggest enabling it by default on newly created clusters by default. Recommended by the CIS GCP Benchmark to be enabled. See: https://www.cisecurity.org/benchmark/google_cloud_computing_platform/

Pros: Allows for support of NetworkPolicy objects if they are applied without having to modify the cluster.
Cons: The slight overhead of Calico agents and Typha in the cluster if NetworkPolicy is unused.
@morgante
Copy link
Contributor

+1

@aaron-lane aaron-lane added the enhancement New feature or request label May 27, 2019
@aaron-lane aaron-lane added the triaged Scoped and ready for work label Nov 16, 2019
@aaron-lane
Copy link
Contributor

Is #315 sufficient or do we want this to be the default on all modules?

@morgante
Copy link
Contributor

morgante commented Nov 18, 2019 •
edited
Loading

Let's default to true on all modules.

@bharathkkb bharathkkb mentioned this issue Nov 28, 2019
Merged
aaron-lane pushed a commit that referenced this issue Nov 29, 2019
Add #138 to CHANGELOG
d426a1e
@ghost ghost mentioned this issue Jan 31, 2021
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Add terraform-google-modules#138 to CHANGELOG
2dc001c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharathkkb bharathkkb

Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable network_policy by default
4 participants
@morgante @bgeesaman @aaron-lane @bharathkkb