Skip to content

Commit

Permalink
feat(beta-autopilot)!: enable gcfs by default (#2066)
Browse files Browse the repository at this point in the history
  • Loading branch information
apeabody authored Sep 10, 2024
1 parent 8b7e342 commit a083437
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 5 deletions.
2 changes: 1 addition & 1 deletion autogen/main/variables.tf.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ variable "enable_gcfs" {
default = false
{% endif %}
{% if autopilot_cluster %}
default = null
default = true
{% endif %}
}
{% endif %}
Expand Down
14 changes: 14 additions & 0 deletions docs/upgrading_to_v33.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,20 @@ To opt out, set `enable_private_nodes` to `false`.
}
```

### Autopilot Cluster GCFS Default
Autopilot cluster modules now set `enable_gcfs` to `true` by default to
aligned with TPGv6. To maintain the previous provider default behavior, set
`enable_gcfs` to `null`.

```diff
module "cluster" {
- version = "~> 32.0"
+ version = "~> 33.0"

+ enable_gcfs = null
}
```

### Advanced Datapath Observability Relay
The `monitoring_observability_metrics_relay_mode` parameter has been
replaced with `monitoring_enable_observability_relay`.
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-autopilot-private-cluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Then perform the following commands on the root folder:
| enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no |
| enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no |
| enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no |
| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `null` | no |
| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `true` | no |
| enable\_l4\_ilb\_subsetting | Enable L4 ILB Subsetting on the cluster | `bool` | `false` | no |
| enable\_network\_egress\_export | Whether to enable network egress metering for this cluster. If enabled, a daemonset will be created in the cluster to meter network egress traffic. | `bool` | `false` | no |
| enable\_private\_endpoint | Whether the master's internal IP address is used as the cluster endpoint | `bool` | `false` | no |
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-autopilot-private-cluster/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ variable "enable_l4_ilb_subsetting" {
variable "enable_gcfs" {
type = bool
description = "(Beta) Enable image streaming on cluster level."
default = null
default = true
}

variable "allow_net_admin" {
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-autopilot-public-cluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Then perform the following commands on the root folder:
| enable\_confidential\_nodes | An optional flag to enable confidential node config. | `bool` | `false` | no |
| enable\_cost\_allocation | Enables Cost Allocation Feature and the cluster name and namespace of your GKE workloads appear in the labels field of the billing export to BigQuery | `bool` | `false` | no |
| enable\_fqdn\_network\_policy | Enable FQDN Network Policies on the cluster | `bool` | `null` | no |
| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `null` | no |
| enable\_gcfs | (Beta) Enable image streaming on cluster level. | `bool` | `true` | no |
| enable\_l4\_ilb\_subsetting | Enable L4 ILB Subsetting on the cluster | `bool` | `false` | no |
| enable\_network\_egress\_export | Whether to enable network egress metering for this cluster. If enabled, a daemonset will be created in the cluster to meter network egress traffic. | `bool` | `false` | no |
| enable\_resource\_consumption\_export | Whether to enable resource consumption metering on this cluster. When enabled, a table will be created in the resource export BigQuery dataset to store resource consumption data. The resulting table can be joined with the resource usage table or with BigQuery billing export. | `bool` | `true` | no |
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-autopilot-public-cluster/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ variable "enable_l4_ilb_subsetting" {
variable "enable_gcfs" {
type = bool
description = "(Beta) Enable image streaming on cluster level."
default = null
default = true
}

variable "allow_net_admin" {
Expand Down

0 comments on commit a083437

Please sign in to comment.