-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added more examples for Rust, Go, Java runtimes #612
Conversation
@MaxymVlasov Do you know why some of the recent upgrade of pre-commit-terraform changes the README files created by terraform_wrapper_module_for_each hook. This made this build fail. I think we should not touch those files created by |
I think that I don't see Marker migration runs right before terraform-docs execution otherwise tool will fail to write any changes. There nothing about "by whom" README was generated, so it can't be disabled inside hook, only inside .pre-comit-config for that hook |
@MaxymVlasov There was no |
So you talking about addition of new sections to the end of files, which looks like setting - id: terraform_docs
args:
- --hook-config=--add-to-existing-file=true was specified or markers was add manually. By default, no markers added => no markers can be replaced too if they didn't exist In any case, if I understand correctly, it comes from your commit, not from CI (if in this repo any autofixes exist) If your configuration never included option above, and you didn't add markers manually, what exactly you did step by step during this commit? Please place a bug report with these steps, so I will be able to reproduce this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - few minor nits
Co-authored-by: Melissa Greenbaum <[email protected]>
Waiting for antonbabenko/pre-commit-terraform#716 by @MaxymVlasov to be merged |
Merged |
## [7.9.0](v7.8.1...v7.9.0) (2024-09-10) ### Features * Added more examples for Rust, Go, Java runtimes ([#612](#612)) ([a6fe411](a6fe411))
This PR is included in version 7.9.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request