Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dynamic logging config for Gov Cloud #541

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: Dynamic logging config for Gov Cloud #541

merged 3 commits into from
Jan 31, 2024

Conversation

AndrewCharlesHay
Copy link
Contributor

Description

Make the logging configuration only an object on the aws partition

Motivation and Context

See #539

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@AndrewCharlesHay
Copy link
Contributor Author

I haven't added tests yet but I will tomorrow. I'd still love a pair of eyes if someone gets a chance 👀

antonbabenko
antonbabenko reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. No need to add anything except maybe a check for China regions if there is a support for logging configuration or not. Could you look for that in the official aws docs and update it here if necessary.

@AndrewCharlesHay
Copy link
Contributor Author

I should have mentioned but there is an issue stating the same problem for China
See hashicorp/terraform-provider-aws#34809

@AndrewCharlesHay
Copy link
Contributor Author

AndrewCharlesHay commented Jan 30, 2024 •
edited
Loading

Here is the official AWS documentation mentioning that it is only commercial cloud

🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦🇺🇦

@antonbabenko antonbabenko merged commit b9a6ea1 into terraform-aws-modules:master Jan 31, 2024
30 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 31, 2024
@semantic-release-bot
chore(release): version 7.2.1 [skip ci]
dc7c19b 
### [7.2.1](v7.2.0...v7.2.1) (2024-01-31)

### Bug Fixes

* Dynamic logging config for Gov Cloud ([#541](#541)) ([b9a6ea1](b9a6ea1))
@antonbabenko
Copy link
Member

This PR is included in version 7.2.1 🎉

@AndrewCharlesHay AndrewCharlesHay deleted the feature/dynamic-logging-config branch January 31, 2024 14:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewCharlesHay @antonbabenko