fix!: Defaults false for enable_mfa_enforcement for IAM groups
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytonchew
changed the title
false for enable_mfa_enforcement for IAM groupsfalse for enable_mfa_enforcement for IAM groups
|
This PR has been automatically marked as stale because it has been open 30 days |
|
/keepalive |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
/keepalive |
|
This PR has been automatically marked as stale because it has been open 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #509
Defaults
enable_mfa_enforcementtofalseas it should be an opt-in feature.Motivation and Context
Users migrating from older version (example version 5.3.1) to current version may find that IAM groups users with
attach_iam_self_management_policyset totruesuddenly lose access to their consoles, which can cause more harm than good.Breaking Changes
This change should maintain backward compatibility for users migrating from versions prior to 5.14.3. However, users having versions 5.14.3 and beyond may find that MFA enforcement no longer being enforced by default, requiring
enable_mfa_enforcementto be explicitly set totrue.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request