Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam-github-oidc-role): Add condition for allowlisting CIDR. #423

Closed

Conversation

alecsiemerink
Copy link

Description

This allows you to pass a list of CIDRs from where the role can be used.
A non-required variable is introduced, that when it is set it will add a condition to the aws_iam_policy_document with the CIDR.

Motivation and Context

#422
This enables more secure use of OIDC by allowing only a specified CIDR to use it. For example, for using self-hosted GitHub Actions runners and allowlisting them.

Breaking Changes

Not that I know of.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@alecsiemerink alecsiemerink changed the title Add condition for allowlisting CIDR. feat(iam-github-oidc-role): Add condition for allowlisting CIDR. Sep 13, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 14, 2023
@alecsiemerink
Copy link
Author

No activity here?

@github-actions github-actions bot removed the stale label Oct 17, 2023
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 16, 2023
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Nov 26, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant