test(memory_arena_threshold): don't expect exact allocation values #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the check for allocation sizes to exactly match expected values. This check immediately followed--and thus rendered pointless---a check that sizes are within a certain percentage, which seems to be the true intent of the test. BUG=see description
suleshahid
approved these changes
Dec 10, 2024
|
This pull request has been removed from the queue for the following reason: Pull request #3005 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 19 of 20 required status checks have not succeeded: 18 expected.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the check for allocation sizes to exactly match expected values.
This check immediately followed--and thus rendered pointless---a check
that sizes are within a certain percentage, which seems to be the true
intent of the test.
BUG=see description