fix(ci): properly pass variables to Make #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the broken CI scripts, new in 23d626d, by passing variable values to Make as command line options rather than through the environment. Variables set in the environment are overridden by assignments in the Makefile, whereas variables set as command line options override assignments in the Makefile. BUG=fixes tensorflow#2989 and fixes tensorflow#2990
|
Could you check the Hifi5 test, still failing. |
suleshahid
approved these changes
Dec 6, 2024
|
This pull request has been removed from the queue for the following reason: Pull request #2993 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 19 of 20 required status checks have not succeeded: 16 expected.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the broken CI scripts, new in 23d626d, by passing variable
values to Make as command line options rather than through the
environment. Variables set in the environment are overridden by
assignments in the Makefile, whereas variables set as command
line options override assignments in the Makefile.
BUG=fixes #2989 and fixes #2990