Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port BATCH_MATMUL #2147

Merged
merged 9 commits into from
Sep 6, 2023
Merged

Conversation

ddavis-2015
Copy link
Member

@tensorflow/micro

Port BATCH_MATMUL kernel from TfLite along with unit tests.

b/291110349

bug=fixes #2146

@tensorflow/micro

Port BATCH_MATMUL kernel from TfLite along with unit tests.

b/291110349

bug=fixes Port BATCH_MATMUL tensorflow#2146
@ddavis-2015 ddavis-2015 requested a review from a team as a code owner July 26, 2023 04:31
@ddavis-2015 ddavis-2015 self-assigned this Jul 26, 2023
@ddavis-2015 ddavis-2015 added bug Something isn't working ci:run_full labels Jul 26, 2023
@ddavis-2015 ddavis-2015 requested a review from advaitjain July 26, 2023 04:32
tensorflow/lite/micro/kernels/batch_matmul.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul.cc Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@rascani rascani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just a couple naming nits.

tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
tensorflow/lite/micro/kernels/batch_matmul_test.cc Outdated Show resolved Hide resolved
@ddavis-2015 ddavis-2015 requested a review from rascani August 17, 2023 19:33
@mergify mergify bot merged commit 5d542d7 into tensorflow:main Sep 6, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port BATCH_MATMUL
4 participants