tfgan_tutorial.ipynb Compatible with TF2.x #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone please check this PR |
|
This change is good in theory, but I think the same can be achieved by changing the single line "import tensorflow as tf" to "import tensorflow.compat.v1 as tf", which is the preferred way of setting the version. Would you mind doing this instead? |
|
No Problem. I ll make the respective changes and commit it. |
|
@joel-shor It's done. |
|
I can't review this with all the changes in output causing noise. Can you just change code, not the outputs, so that I can review it? Or else if you hav a suggestion on how to review this without that, please let me know. |
joel-shor
suggested changes
Mar 8, 2020
|
@joel-shor It's done I have just changed the code. Left the output as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18
Code Migrated to TF2.x