Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus update branch #237

Closed
wants to merge 193 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 25, 2022

This branch is being used in production by notional on evmos.

The performance is strikingly better, see #248

This branch can be built with ease for chains with high resource demands as follows:

#248

docker run ghcr.io/faddat/cosmos -c /bin/bash
git clone your-chain-repo
cd your-chain-repo
go mod edit -replace github.com/tendermint/tm-db=github.com/notional-labs/tmdb@commit
go mod tidy
go install -ldflags '-w -s -X github.com/cosmos/cosmos-sdk/types.DBBackend=rocksdb' -tags rocksdb ./...

above you can change rocksdb to the database you'd like to try.

In total, this branch integrates

  • a fix to rocksdb that allows it to make the snapshots folder
  • migration from cosmos/gorockdb to a standard, well-maintained rocks wrapper, linxgnu/grocksdb
  • Terra's removal of the prefixdb mutex
  • Additional tweaks to goleveldb and rocksdb from the terra team

@faddat
Copy link
Contributor Author

faddat commented Apr 25, 2022

Though realistically I don't see issues with any of this, except that we'd still be using an out of date rocksdb

NB: All I've really done is the upstreaming work here--

hanjukim

and

https://github.com/kjessec

are the primary authors

@faddat
Copy link
Contributor Author

faddat commented Jul 4, 2022

@creachadair sir, I sorta hate to trouble you w/ this but I'm going to r4r this and guess that I'd like to request you be brutal to it. We use this in prod on:

  • approximately 100 various nodes that we relay and serve rpcs from
  • our evmos and osmosis validators

It has been very stable, but changes many things. If you do not have time for it, I totally understand.

@faddat faddat marked this pull request as ready for review July 4, 2022 21:44
@faddat faddat marked this pull request as draft July 29, 2022 10:34
@faddat
Copy link
Contributor Author

faddat commented Jul 29, 2022

@marbar3778 please note that this is in desperate need of cleanup.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#237 update

@faddat
Copy link
Contributor Author

faddat commented Aug 2, 2022

FYI, I am keeping this one alive mainly for historical and visibility purposes. I intend to close it this week. I want to grab the goleveldb settings from here though.

This branch contains #250 which some anon coder convinced me didn't include enough evidence. He was right.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 8, 2022
@github-actions github-actions bot closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants