Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/merkle: pre-allocate data slice in innherHash (#6443) #9447

Merged
merged 3 commits into from
Sep 21, 2022
Merged

crypto/merkle: pre-allocate data slice in innherHash (#6443) #9447

merged 3 commits into from
Sep 21, 2022

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Sep 16, 2022 •
edited
Loading

Cherry-picking PR #6443

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@JayT106
crypto/merkle: pre-allocate data slice in innherHash (tendermint#6443)
87d48c2 
So we can reduce pressure on runtime for checking that slice has enough
capacity before appending.
@JayT106 JayT106 requested a review from ebuchman as a code owner September 16, 2022 20:14
@JayT106 JayT106 requested a review from a team September 16, 2022 20:14
@cmwaters cmwaters added the S:automerge Automatically merge PR when requirements pass label Sep 21, 2022
@mergify mergify bot merged commit bfdeccd into tendermint:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayT106 @cmwaters