Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/tendermint/commands: replace $HOME/.some/test/dir with t.TempDir #6623

Merged
merged 5 commits into from
Jun 28, 2021
Merged

cmd/tendermint/commands: replace $HOME/.some/test/dir with t.TempDir #6623

merged 5 commits into from
Jun 28, 2021

Conversation

tanyabouman
Copy link

Closes #6605

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. this looks good!! Hope to see you contribute more.

@tac0turtle tac0turtle added S:automerge Automatically merge PR when requirements pass T:test Type: Tests that need love labels Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #6623 (7f4277c) into master (7eef4d7) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6623      +/-   ##
==========================================
- Coverage   60.99%   60.90%   -0.09%     
==========================================
  Files         297      297              
  Lines       28065    28065              
==========================================
- Hits        17119    17094      -25     
- Misses       9222     9241      +19     
- Partials     1724     1730       +6     
Impacted Files Coverage Δ
privval/signer_server.go 89.47% <0.00%> (-5.27%) ⬇️
privval/signer_endpoint.go 78.78% <0.00%> (-3.04%) ⬇️
internal/consensus/reactor.go 65.89% <0.00%> (-2.92%) ⬇️
internal/statesync/dispatcher.go 87.31% <0.00%> (-2.24%) ⬇️
internal/statesync/block_queue.go 94.39% <0.00%> (-1.87%) ⬇️
internal/consensus/peer_state.go 79.82% <0.00%> (-0.88%) ⬇️
internal/consensus/state.go 67.35% <0.00%> (-0.28%) ⬇️
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
internal/p2p/conn/connection.go 79.12% <0.00%> (+0.54%) ⬆️
internal/statesync/syncer.go 80.60% <0.00%> (+0.76%) ⬆️
... and 2 more

@tac0turtle tac0turtle merged commit 09ec247 into tendermint:master Jun 28, 2021
@tanyabouman tanyabouman deleted the replace-home-dir-test branch July 7, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatically merge PR when requirements pass T:test Type: Tests that need love
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/tendermint/commands: use a generated temporary directory
3 participants