Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evidence: json tags for DuplicateVoteEvidence #4959

Merged
merged 2 commits into from
Jun 4, 2020
Merged

evidence: json tags for DuplicateVoteEvidence #4959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf525b
add json tags to duplicate vote
tac0turtle Jun 4, 2020
c385ceb
add changelog entry
tac0turtle Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi
- multisig: type `PubKeyMultisigThreshold` is now `PubKey`
- [light] \#4946 Rename `lite2` pkg to `light`, the lite cmd has also been renamed to `light`. Remove `lite` implementation.
- [rpc] \#4937 Return an error when `page` pagination param is 0 in `/validators`, `tx_search` (@melekes)
- [evidence] \#4959 Add json tags to `DuplicateVoteEvidence`

- Apps

Expand Down
4 changes: 2 additions & 2 deletions types/evidence.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,8 @@ func RegisterMockEvidences(cdc *amino.Codec) {
// DuplicateVoteEvidence contains evidence a validator signed two conflicting
// votes.
type DuplicateVoteEvidence struct {
VoteA *Vote
VoteB *Vote
VoteA *Vote `json:"vote_a"`
VoteB *Vote `json:"vote_b"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like we need also need to remove the pubkey field in the rust version too: https://github.com/informalsystems/tendermint-rs/pull/242/files#r417475910

}

var _ Evidence = &DuplicateVoteEvidence{}
Expand Down