Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signing: change signbytes #4852

Merged
merged 4 commits into from
May 20, 2020
Merged

Conversation

tac0turtle
Copy link
Contributor

Description

have SignBytes accept a proto type

Closes: #XXX

@tac0turtle tac0turtle self-assigned this May 18, 2020
@auto-comment
Copy link

auto-comment bot commented May 18, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle added the T:encoding Type: Amino, ProtoBuf label May 19, 2020
@tac0turtle tac0turtle marked this pull request as ready for review May 19, 2020 10:02
@tac0turtle tac0turtle requested review from melekes and tessr as code owners May 19, 2020 10:02
@tac0turtle tac0turtle requested a review from erikgrinaker May 19, 2020 10:02
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (marko/canonical@58c37a6). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             marko/canonical    #4852   +/-   ##
==================================================
  Coverage                   ?   61.14%           
==================================================
  Files                      ?      167           
  Lines                      ?    14506           
  Branches                   ?        0           
==================================================
  Hits                       ?     8869           
  Misses                     ?     4848           
  Partials                   ?      789           

@tac0turtle
Copy link
Contributor Author

going to merge this into the privval proto migration so it can be reviewed at once

@tac0turtle tac0turtle merged commit d2de7c6 into marko/canonical May 20, 2020
@tac0turtle tac0turtle deleted the marko/change_vote_signbytes branch May 20, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:encoding Type: Amino, ProtoBuf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants