Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs/kv: remove unused type KI64Pair #4542

Merged
merged 3 commits into from
Mar 10, 2020
Merged

libs/kv: remove unused type KI64Pair #4542

merged 3 commits into from
Mar 10, 2020

Conversation

tessr
Copy link
Contributor

@tessr tessr commented Mar 9, 2020

This type does not seem to be used. See also: #4466 (comment)

@tessr tessr marked this pull request as ready for review March 9, 2020 17:38
@tessr tessr requested review from ebuchman and melekes as code owners March 9, 2020 17:38
@tessr
Copy link
Contributor Author

tessr commented Mar 9, 2020

(Proto-breakage is failing because the generated files changed, but that's the point of this change.)

melekes
melekes approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes
Copy link
Contributor

melekes commented Mar 10, 2020

This needs a changelog entry.

@tessr
Copy link
Contributor Author

tessr commented Mar 10, 2020

Good call, thanks.

@tessr tessr merged commit 31bea92 into master Mar 10, 2020
@tessr tessr deleted the tessr/ki64 branch March 10, 2020 20:34
cmwaters pushed a commit that referenced this pull request Mar 25, 2020
@tessr @cmwaters
libs/kv: remove unused type KI64Pair (#4542)
29bcb26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tessr @melekes