Rc2/v0.32.8 #4101

tac0turtle · 2019-10-31T22:23:12Z

Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Updated CHANGELOG_PENDING.md

* Remove go func {}() closes #357 - Remove go func(){}() that caused race condiditon - To reproduce - add -race in make file to `install_abci` - Remove `CGO_ENABLED=0` & add -race to `install` Signed-off-by: Marko Baricevic <[email protected]> * remove -race * fix data race also, reorder callbacks similarly to socket client

…3608) * docs: go built-in guide * fix package imports, add badger db, simplify Query * newTendermint function * working example * finish the first guide * add one more note * add the second Golang guide - external ABCI app * fix typos

* Remove db from tendemrint in favor of tendermint/tm-cmn - remove db from `libs` - update dependancy, there have been no breaking changes in the updated deps - https://github.com/grpc/grpc-go/releases - https://github.com/golang/protobuf/releases Signed-off-by: Marko Baricevic <[email protected]> * changelog add * gofmt * more gofmt

* ADR TOC in readme.md * Added A TOC to the Readme.md of ADR Section - Added table of contents to the Readme of the architecture section. - Easier to traverse and when you know what is there. - If the Adr's become viewable online it would help guide the user Signed-off-by: Marko Baricevic <[email protected]> * add tm-cmn to subprojects * normalize word

* rpc: make max_body_bytes and max_header_bytes configurable * update changelog pending

* use byte buffer pool to decreass allocs * wrap to put buffer in defer * wapper defer * add dependency * remove Gopkg,* * add change log

* implement broadcast_duplicate_vote endpoint * fix test_cover * address comments * address comments * Update abci/example/kvstore/persistent_kvstore.go Co-Authored-By: mossid <[email protected]> * Update rpc/client/main_test.go Co-Authored-By: mossid <[email protected]> * address comments in progress * reformat the code * make linter happy * make tests pass * replace BroadcastDuplicateVote with BroadcastEvidence * fix test * fix endpoint name * improve doc * fix TestBroadcastEvidenceDuplicateVote * Update rpc/core/evidence.go Co-Authored-By: Thane Thomson <[email protected]> * add changelog entry * fix TestBroadcastEvidenceDuplicateVote

* mempool: make max_msg_bytes configurable * apply suggestions from code review * update changelog pending * apply suggestions from code review again

#3825) * rpc: return err if page is incorrect (less than 0 or greater than total pages) Fixes #3813 * fix rpc_test

* go routines in blockchain reactor * Added reference to the go routine diagram * Initial commit * cleanup * Undo testing_logger change, committed by mistake * Fix the test loggers * pulled some fsm code into pool.go * added pool tests * changes to the design added block requests under peer moved the request trigger in the reactor poolRoutine, triggered now by a ticker in general moved everything required for making block requests smarter in the poolRoutine added a simple map of heights to keep track of what will need to be requested next added a few more tests * send errors to FSM in a different channel than blocks send errors (RemovePeer) from switch on a different channel than the one receiving blocks renamed channels added more pool tests * more pool tests * lint errors * more tests * more tests * switch fast sync to new implementation * fixed data race in tests * cleanup * finished fsm tests * address golangci comments :) * address golangci comments :) * Added timeout on next block needed to advance * updating docs and cleanup * fix issue in test from previous cleanup * cleanup * Added termination scenarios, tests and more cleanup * small fixes to adr, comments and cleanup * Fix bug in sendRequest() If we tried to send a request to a peer not present in the switch, a missing continue statement caused the request to be blackholed in a peer that was removed and never retried. While this bug was manifesting, the reactor kept asking for other blocks that would be stored and never consumed. Added the number of unconsumed blocks in the math for requesting blocks ahead of current processing height so eventually there will be no more blocks requested until the already received ones are consumed. * remove bpPeer's didTimeout field * Use distinct err codes for peer timeout and FSM timeouts * Don't allow peers to update with lower height * review comments from Ethan and Zarko * some cleanup, renaming, comments * Move block execution in separate goroutine * Remove pool's numPending * review comments * fix lint, remove old blockchain reactor and duplicates in fsm tests * small reorg around peer after review comments * add the reactor spec * verify block only once * review comments * change to int for max number of pending requests * cleanup and godoc * Add configuration flag fast sync version * golangci fixes * fix config template * move both reactor versions under blockchain * cleanup, golint, renaming stuff * updated documentation, fixed more golint warnings * integrate with behavior package * sync with master * gofmt * add changelog_pending entry * move to improvments * suggestion to changelog entry

* Renamed wire.go to codec.go - Wire was the previous name of amino - Codec describes the file better than `wire` & `amino` Signed-off-by: Marko Baricevic <[email protected]> * ide error * rename amino.go to codec.go

cleanup to add linter grpc change: https://godoc.org/google.golang.org/grpc#WithContextDialer https://godoc.org/google.golang.org/grpc#WithDialer grpc/grpc-go#2627 prometheous change: due to UninstrumentedHandler, being deprecated in the future empty branch = empty if or else statement didn't delete them entirely but commented couldn't find a reason to have them could not replicate the issue #3406 but if want to keep it commented then we should comment out the if statement as well

to the types package Paritally Fixes #3584

* p2p: fix false-positive error logging when stopping connections This changeset fixes two types of false-positive errors occurring during connection shutdown. The first occurs when the process invokes FlushStop() or Stop() on a connection. While the previous behavior did properly wait for the sendRoutine to finish, it did not notify the recvRoutine that the connection was shutting down. This would cause the recvRouting to receive and error when reading and log this error. The changeset fixes this by notifying the recvRoutine that the connection is shutting down. The second occurs when the connection is terminated (gracefully) by the other side. The recvRoutine would get an EOF error during the read, log it, and stop the connection with an error. The changeset detects EOF and gracefully shuts down the connection. * bring back the comment about flushing * add changelog entry * listen for quitRecvRoutine too * we have to call stopForError Otherwise peer won't be removed from the peer set and maybe readded later.

…ds (#3834) * Do not write 'Couldn't connect to any seeds' if there are no seeds * changelog * remove privValUpgrade * Fix typo in changelog * Update CHANGELOG_PENDING.md Co-Authored-By: Marko <[email protected]> I'm setting up all peers dynamically by calling dial_peers, so p2p.seeds in configs is empty, and I'm seeing error log a lot in logs.

…3838) * add abci grpc kotlin guide * Update docs/guides/kotlin.md Co-Authored-By: Anton Kaliaev <[email protected]> * Update docs/guides/kotlin.md Co-Authored-By: Anton Kaliaev <[email protected]> * Update docs/guides/kotlin.md Co-Authored-By: Anton Kaliaev <[email protected]> * Update kotlin.md

* node: allow replacing existing p2p.Reactor(s) using [`CustomReactors` option](https://godoc.org/github.com/tendermint/tendermint/node#CustomReactors). Warning: beware of accidental name clashes. Here is the list of existing reactors: MEMPOOL, BLOCKCHAIN, CONSENSUS, EVIDENCE, PEX. * check the absence of "CUSTOM" prefix * merge 2 tests * add doc.go to node package

Add gocritic as a linter The linting is not complete, but should i complete in this PR or in a following. 23 files have been touched so it may be better to do in a following PR Commits: * Add gocritic to linting - Added gocritic to linting Signed-off-by: Marko Baricevic <[email protected]> * gocritic * pr comments * remove switch in cmdBatch

* tm-cmn to tm-db * go.mod changes * go.mod changes * more go.mod * fix tm-db * ci fix, pending change

- Replace the previous intersect call, which was called at each query condition, with a map intersection. - Replace fmt.Sprintf with string() closes: #3076 Benchmarks ``` Old goos: darwin goarch: amd64 pkg: github.com/tendermint/tendermint/state/txindex/kv BenchmarkTxSearch-4 200 103641206 ns/op 7998416 B/op 71171 allocs/op PASS ok github.com/tendermint/tendermint/state/txindex/kv 26.019s New goos: darwin goarch: amd64 pkg: github.com/tendermint/tendermint/state/txindex/kv BenchmarkTxSearch-4 1000 38615024 ns/op 13515226 B/op 166460 allocs/op PASS ok github.com/tendermint/tendermint/state/txindex/kv 53.618s ``` ~62% performance improvement Commits: * Refactor tx search * Add pending changelog entry * Add tx search benchmarking * remove intermediate hashes list also reset timer in BenchmarkTxSearch and fix other benchmark * fix import * Add test cases * Fix searching * Replace fmt.Sprintf with string * Update state/txindex/kv/kv.go Co-Authored-By: Anton Kaliaev <[email protected]> * Rename params * Cleanup * Check error in benchmarks

* changelog updates * pr comments

v0.32.3

Release/v0.32.4

abci/tests/test_app/main.go

.circleci/config.yml

.github/stale.yml

melekes · 2019-11-11T13:04:32Z

abci/types/application.go

@@ -18,7 +18,7 @@ type Application interface {
 	CheckTx(RequestCheckTx) ResponseCheckTx // Validate a tx for the mempool

 	// Consensus Connection
-	InitChain(RequestInitChain) ResponseInitChain    // Initialize blockchain with validators and other info from TendermintCore
+	InitChain(RequestInitChain) ResponseInitChain    // Initialize blockchain w validators/other info from TendermintCore


consensus/reactor_test.go

consensus/state.go

melekes · 2019-11-11T13:49:08Z

docs/app-dev/getting-started.md

+need to [install Go](https://golang.org/doc/install), put
+`$GOPATH/bin` in your `$PATH` and enable go modules with these instructions:
+```bash
+echo export GOPATH=\"\$HOME/go\" >> ~/.bash_profile


I don't believe newer Golang versions require setting GOPATH, but that's fine for now

libs/pubsub/pubsub.go

rpc/lib/client/ws_client.go

melekes · 2019-11-11T14:08:13Z

also needs changelog update

tac0turtle · 2019-11-12T12:10:03Z

CHANGELOG.md

@@ -1,8 +1,37 @@
 # Changelog


ahhh sorry it auto formatted, let me know if you want me to undo it

melekes · 2019-11-12T14:10:29Z

Please refrain from rebasing & force-pushing next time. When/if you do a git rebase and force-push, we can't review only new changes and forced to review everything.

melekes · 2019-11-13T05:56:14Z

CHANGELOG.md

+- [mempool] [\#4083](https://github.com/tendermint/tendermint/pull/4083) Added TxInfo parameter to CheckTx(), and removed CheckTxWithInfo() (@erikgrinaker)
+- [mempool] [\#4057](https://github.com/tendermint/tendermint/issues/4057) Include peer ID when logging rejected txns (@erikgrinaker)
+- [tools] [\#4023](https://github.com/tendermint/tendermint/issues/4023) Improved `tm-monitor` formatting of start time and avg tx throughput (@erikgrinaker)
+- [libs/pubsub] [\#4070](https://github.com/tendermint/tendermint/pull/4070) Strip out non-numeric characters when attempting to match numeric values.


tac0turtle · 2019-11-13T10:45:52Z

this pr started from master and now has different commits from master, a bit lost what is going on. the same thing happened on rc1, i started a rc3 branch to test it out and it does not have the same issue #4135

melekes

alexdupre and others added 30 commits August 1, 2019 10:28

docs: fix consensus spec formatting (#3804)

9df1177

abci/server: recover from app panics in socket server (#3809)

9867a65

fixes #3800

rpc: make max_body_bytes and max_header_bytes configurable (#3818)

5d7e22a

* rpc: make max_body_bytes and max_header_bytes configurable * update changelog pending

p2p/conn: Add Bufferpool (#3664)

17b69d4

* use byte buffer pool to decreass allocs * wrap to put buffer in defer * wapper defer * add dependency * remove Gopkg,* * add change log

mempool: make max_msg_bytes configurable (#3826)

df6df61

* mempool: make max_msg_bytes configurable * apply suggestions from code review * update changelog pending * apply suggestions from code review again

rpc: return err if page is incorrect (less than 0 or greater than tot… (

e89991c

#3825) * rpc: return err if page is incorrect (less than 0 or greater than total pages) Fixes #3813 * fix rpc_test

Renamed wire.go to codec.go (#3827)

5d0e703

* Renamed wire.go to codec.go - Wire was the previous name of amino - Codec describes the file better than `wire` & `amino` Signed-off-by: Marko Baricevic <[email protected]> * ide error * rename amino.go to codec.go

docs: add guides to docs (#3830)

0335add

types: move MakeVote / MakeBlock functions (#3819)

58c3e59

to the types package Paritally Fixes #3584

docs: add a footer to guides (#3835)

5f6617d

tm-cmn to tm-db (#3850)

8025d40

* tm-cmn to tm-db * go.mod changes * go.mod changes * more go.mod * fix tm-db * ci fix, pending change

version tmdb (#3854)

d56fb6e

release for v0.32.2

15878dc

Merge PR #3860: Update log v0.32.2

76f3db0

* changelog updates * pr comments

Merge branch 'master' into v0.32

86a581f

Merge pull request #3926 from tendermint/anton/v0.32.3

0ad70fb

v0.32.3

Merge pull request #4002 from tendermint/release/v0.32.4

ff2308b

Release/v0.32.4

tac0turtle self-assigned this Nov 11, 2019

tac0turtle added the R4R label Nov 11, 2019

tac0turtle marked this pull request as ready for review November 11, 2019 11:13

tac0turtle requested review from ebuchman, melekes and xla as code owners November 11, 2019 11:13

golangcibot reviewed Nov 11, 2019

View reviewed changes

abci/tests/test_app/main.go Outdated Show resolved Hide resolved

tac0turtle force-pushed the rc2/v0.32.8 branch from 8b08f4e to 3e62a9f Compare November 11, 2019 11:30

melekes reviewed Nov 11, 2019

View reviewed changes

libs/pubsub/pubsub.go Show resolved Hide resolved

rpc/lib/client/ws_client.go Outdated Show resolved Hide resolved

tac0turtle force-pushed the rc2/v0.32.8 branch 2 times, most recently from d980e7c to 5b0abe6 Compare November 12, 2019 12:05

Merge branch 'v0.32' into rc2/v0.32.8

a283fd1

tac0turtle force-pushed the rc2/v0.32.8 branch from 5b0abe6 to a283fd1 Compare November 12, 2019 12:08

tac0turtle commented Nov 12, 2019

View reviewed changes

CHANGELOG.md

@@ -1,8 +1,37 @@

# Changelog

Copy link

Contributor Author

tac0turtle Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh sorry it auto formatted, let me know if you want me to undo it

melekes reviewed Nov 13, 2019

View reviewed changes

melekes approved these changes Nov 13, 2019

View reviewed changes

melekes mentioned this pull request Nov 13, 2019

circleci: use cache again #4133

Closed

Merge branch 'master' into rc2/v0.32.8

c0419ec

tac0turtle changed the base branch from v0.32 to release/v0.32.8 November 13, 2019 10:32

tac0turtle changed the base branch from release/v0.32.8 to master November 13, 2019 10:33

tac0turtle mentioned this pull request Nov 13, 2019

[test]Rc3 for 0.32.8 #4135

Closed

5 tasks

melekes approved these changes Nov 13, 2019

View reviewed changes

tac0turtle changed the base branch from master to release/v0.32.8 November 13, 2019 16:03

melekes approved these changes Nov 14, 2019

View reviewed changes

tessr merged commit 9553028 into release/v0.32.8 Nov 19, 2019

tessr deleted the rc2/v0.32.8 branch November 19, 2019 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rc2/v0.32.8 #4101

Rc2/v0.32.8 #4101

tac0turtle commented Oct 31, 2019

melekes Nov 11, 2019

melekes Nov 11, 2019

melekes commented Nov 11, 2019

tac0turtle Nov 12, 2019

melekes commented Nov 12, 2019

melekes Nov 13, 2019

tac0turtle commented Nov 13, 2019

melekes left a comment

Rc2/v0.32.8 #4101

Rc2/v0.32.8 #4101

Conversation

tac0turtle commented Oct 31, 2019

melekes Nov 11, 2019

Choose a reason for hiding this comment

melekes Nov 11, 2019

Choose a reason for hiding this comment

melekes commented Nov 11, 2019

tac0turtle Nov 12, 2019

Choose a reason for hiding this comment

melekes commented Nov 12, 2019

melekes Nov 13, 2019

Choose a reason for hiding this comment

tac0turtle commented Nov 13, 2019

melekes left a comment

Choose a reason for hiding this comment