Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool WAL is still created by default in home directory, leads to permission errors #2758

Merged
merged 3 commits into from
Nov 6, 2018

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 5, 2018

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@melekes melekes requested review from ebuchman and xla as code owners November 5, 2018 16:20
@codecov-io
Copy link

Codecov Report

Merging #2758 into develop will increase coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #2758      +/-   ##
===========================================
+ Coverage    62.21%   62.21%   +<.01%     
===========================================
  Files          212      212              
  Lines        17136    17181      +45     
===========================================
+ Hits         10661    10690      +29     
- Misses        5577     5593      +16     
  Partials       898      898
Impacted Files Coverage Δ
config/config.go 68.77% <0%> (-0.52%) ⬇️
node/node.go 64.9% <0%> (-0.66%) ⬇️
mempool/mempool.go 74.34% <50%> (+0.16%) ⬆️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
libs/db/mem_db.go 82.9% <0%> (-2.39%) ⬇️
p2p/pex/pex_reactor.go 73.05% <0%> (-0.33%) ⬇️
libs/db/types.go 100% <0%> (ø) ⬆️
consensus/reactor.go 67.36% <0%> (ø) ⬆️
blockchain/pool.go 66.43% <0%> (+0.69%) ⬆️
privval/tcp_server.go 81.42% <0%> (+2.85%) ⬆️

@ebuchman ebuchman merged commit b8a9b0b into develop Nov 6, 2018
@ebuchman ebuchman deleted the 2717-mempool-still-created branch November 6, 2018 06:39
maxim-levy pushed a commit to maxim-levy/tendermint that referenced this pull request Nov 13, 2018
* 'master' of https://github.com/tendermint/tendermint: (330 commits)
  Release/v0.26.1 (tendermint#2803)
  fix amino overhead computation for Tx (tendermint#2792)
  p2p: re-check after sleeps (tendermint#2664)
  check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787)
  p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797)
  test AutoFile#Size (happy path)
  [autofile/group] do not panic when checking size
  openFile creates a file if not exist => ErrNotExist is not possible
  use our logger in autofile/group
  Add tests for ValidateBasic methods (tendermint#2754)
  [docs] improve organization of ABCI docs & fix links (tendermint#2749)
  p2p: peer-id -> peer_id (tendermint#2771)
  mempool: print postCheck error (tendermint#2762)
  Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756)
  Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758)
  mempool: ErrPreCheck and more log info (tendermint#2724)
  Release/v0.26.0 (tendermint#2726)
  [ADR] [DRAFT] pubsub 2.0 (tendermint#2532)
  validate reactor messages (tendermint#2711)
  TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants