Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SDK v0.46.0 #192

Merged
merged 33 commits into from
Aug 26, 2022
Merged

feat: SDK v0.46.0 #192

merged 33 commits into from
Aug 26, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 26, 2022

Description

Updates the Cosmos SDK to v0.46.0. Please review this PR after the other onces I have submitted are completed.

This PR builds off of those, and will be much more manageable to review if the other PRs are already merged.

  • makes changes according to the changelog
  • adds genesisStateWithValSet() function to run keeper testing suites with a staked validator. Tests panic without this modification.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aljo242
Copy link
Contributor Author

aljo242 commented Jul 31, 2022

I can't reproduce these lint errors locally. They seem to be an error finding imports from the SDK.

Only other error is codecov.

@jaybxyz
Copy link
Contributor

jaybxyz commented Aug 17, 2022

@aljo242 Yeah, I think it was indeed the github workflow issue. I resolved the issue.

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmos SDK v0.46.0 contains important updates and many more minor and module-level changes that requires lots of attention. Great work overall and thank you for the PR. LGTM.

app/app.go Outdated Show resolved Hide resolved
@jaybxyz jaybxyz merged commit bf26b82 into tendermint:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants