Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Templates Typo #268

Closed
jenoOvchi opened this issue May 4, 2021 · 5 comments · Fixed by #316
Closed

Trigger Templates Typo #268

jenoOvchi opened this issue May 4, 2021 · 5 comments · Fixed by #316
Assignees

Comments

@jenoOvchi
Copy link

In the pargraph "To enable support for arbitrary resource types, the resource templates are internally resolved as byte blobs. As a result, validation on these resources is only done at event processing time (rather than during TriggerTemplate creation). 🚨 As of now, only Tekton resources can be defined within a TriggerTemplate 🚨" rotating_light are not applyed to the last sentence.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021
@afrittoli
Copy link
Member

@jenoOvchi thank you for the issue report and sorry about the late reply.
Could you please include a link to the page where you see the issue?

@afrittoli
Copy link
Member

Never mind - found the issue in https://tekton.dev/vault/triggers-v0.9.1/triggertemplates/

From hugo docs, it looks like hugo can supports this syntax, but it may need to be enabled, as it's disabled by default.

@AlanGreene
Copy link
Member

Looks like https://tekton.dev/docs/triggers/triggertemplates/ but that content was removed / rewritten in tektoncd/triggers#981.

Do we need to go back and fix this in previous versions? Also should we be using this emoji syntax or actual unicode emoticons instead?

@afrittoli
Copy link
Member

Looks like https://tekton.dev/docs/triggers/triggertemplates/ but that content was removed / rewritten in tektoncd/triggers#981.

Do we need to go back and fix this in previous versions? Also should we be using this emoji syntax or actual unicode emoticons instead?

I'm not sure we need to go back and fix things as old as v0.9.1 - however since hugo supports the emoji syntax with colons :<name>: we could enable it anyways - I tried it locally and it works fine.

afrittoli added a commit to afrittoli/tektoncd-website that referenced this issue Nov 4, 2021
Hugo supports markdown emojis in the :<name>: format by they are
disabled by default. Enable them as might be used in Tekton docs.

Fixes tektoncd#268

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli mentioned this issue Nov 4, 2021
1 task
@afrittoli afrittoli self-assigned this Nov 4, 2021
@afrittoli afrittoli removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2021
tekton-robot pushed a commit that referenced this issue Nov 14, 2021
Hugo supports markdown emojis in the :<name>: format by they are
disabled by default. Enable them as might be used in Tekton docs.

Fixes #268

Signed-off-by: Andrea Frittoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants