Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions for TriggerTemplates and TriggerBindings #991

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Update descriptions for TriggerTemplates and TriggerBindings #991

merged 1 commit into from
Mar 10, 2021

Conversation

tualeron
Copy link
Contributor

Changes

Updates descriptions for TriggerTemplates and TriggerBindings to correct technical inaccuracies.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 10, 2021
@tekton-robot tekton-robot requested review from dlorenc and khrm March 10, 2021 16:01
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2021
@tualeron
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 10, 2021
@tualeron
Copy link
Contributor Author

/assign @dibyom

docs/README.md Outdated Show resolved Hide resolved
Updates descriptions for `TriggerTemplates` and `TriggerBindings` to correct technical inaccuracies.
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@tekton-robot tekton-robot merged commit c17e848 into tektoncd:main Mar 10, 2021
@tualeron tualeron deleted the patch-2 branch March 10, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants