Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triggers, community and cli reference to use main… #987

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 9, 2021

Changes

… instead of master.

/cc @afrittoli @bobcatfish
/cc @tektoncd/triggers-maintainers @tektoncd/triggers-collaborators

/hold
/kind misc

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

… instead of master.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot requested review from afrittoli, bobcatfish and a team March 9, 2021 17:19
@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2021
@dibyom
Copy link
Member

dibyom commented Mar 9, 2021

/test pull-tekton-triggers-integration-tests

@vdemeester
Copy link
Member Author

        {"level":"error","ts":"2021-03-09T20:52:37.373Z","logger":"webhook-triggers.ConfigMapWebhook","caller":"controller/controller.go:540","msg":"Reconcile error","duration":0.000051573,"error":"secret \"triggers-webhook-certs\" is missing \"ca-cert.pem\" key","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\tknative.dev/[email protected]/controller/controller.go:540\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\tknative.dev/[email protected]/controller/controller.go:523\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/[email protected]/controller/controller.go:460"}

@vdemeester
Copy link
Member Author

default            13m         Warning   FailedCreate                   replicaset/el-cel-eventlistener-no-filter-7cccc4454b                       Error creating: pods "el-cel-eventlistener-no-filter-7cccc4454b-" is forbidden: error looking up service account default/tekton-triggers-example-sa: serviceaccount "tekton-triggers-example-sa" not found
default            13m         Normal    ScalingReplicaSet              deployment/el-cel-eventlistener-no-filter                                  Scaled up replica set el-cel-eventlistener-no-filter-7cccc4454b to 1
default            13m         Warning   FailedCreate                   replicaset/el-cel-listener-interceptor-569dd58cd8                          Error creating: pods "el-cel-listener-interceptor-569dd58cd8-" is forbidden: error looking up service account default/tekton-triggers-example-sa: serviceaccount "tekton-triggers-example-sa" not found
default            13m         Warning   FailedCreate                   replicaset/el-cel-listener-interceptor-with-secret-comparison-7b49d6fffb   Error creating: pods "el-cel-listener-interceptor-with-secret-comparison-7b49d6fffb-" is forbidden: error looking up service account default/tekton-triggers-example-sa: serviceaccount "tekton-triggers-example-sa" not found
default            13m         Normal    ScalingReplicaSet              deployment/el-cel-listener-interceptor-with-secret-comparison              Scaled up replica set el-cel-listener-interceptor-with-secret-comparison-7b49d6fffb to 1
default            13m         Normal    ScalingReplicaSet              deployment/el-cel-listener-interceptor                                     Scaled up replica set el-cel-listener-interceptor-569dd58cd8 to 1
default            13m         Warning   FailedCreate                   replicaset/el-example-with-multiple-overlays-64b56fc756                    Error creating: pods "el-example-with-multiple-overlays-64b56fc756-" is forbidden: error looking up service account default/tekton-triggers-example-sa: serviceaccount "tekton-triggers-example-sa" not found

@vdemeester
Copy link
Member Author

default            13m         Warning   InspectFailed                  pod/gh-validate-6fb777c8f7-xt9ct                                           Failed to apply default image tag "ko://github.com/tektoncd/triggers/examples/event-interceptors": couldn't parse image reference "ko://github.com/tektoncd/triggers/examples/event-interceptors": invalid reference format
default            13m         Warning   Failed                         pod/gh-validate-6fb777c8f7-xt9ct                                           Error: InvalidImageName

🤔

@savitaashture
Copy link
Contributor

default            13m         Warning   InspectFailed                  pod/gh-validate-6fb777c8f7-xt9ct                                           Failed to apply default image tag "ko://github.com/tektoncd/triggers/examples/event-interceptors": couldn't parse image reference "ko://github.com/tektoncd/triggers/examples/event-interceptors": invalid reference format
default            13m         Warning   Failed                         pod/gh-validate-6fb777c8f7-xt9ct                                           Error: InvalidImageName

Strange!! I m able to make it work locally

@vdemeester
Copy link
Member Author

@savitaashture yeah I don't get why it fails on the CI 🤔

@vdemeester
Copy link
Member Author

/retest

Base automatically changed from master to main March 10, 2021 15:03
@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2021
@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
@tekton-robot tekton-robot merged commit 972984a into tektoncd:main Mar 10, 2021
@vdemeester vdemeester deleted the rename-to-main branch March 10, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants