Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Event Body for Json Format #969

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 24, 2021

Throw the Error Message and Bad Request Code if event Body isn't JSON.
Fixes: #656

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

We throw http.BadRequest status code(400) if event payload isn't json.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 24, 2021
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/validate_payload.go Do not exist 0.0%

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/validate_payload.go Do not exist 77.8%

@khrm
Copy link
Contributor Author

khrm commented Feb 24, 2021

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/validate_payload.go Do not exist 77.8%

@khrm khrm removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021
Throw Error Message and Bad Request Code if event Body isn't json.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/validate_payload.go Do not exist 77.8%

@dibyom
Copy link
Member

dibyom commented Feb 25, 2021

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@dibyom
Copy link
Member

dibyom commented Feb 25, 2021

eventlistener_test.go:334: EventListener is ready
eventlistener_test.go:449: sink did not return 2xx response. Got status code: 500
eventlistener_test.go:457: failed to read/decode sink response: EOF

Hmmm looks like the integration test failures are not flakes

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021
@khrm
Copy link
Contributor Author

khrm commented Feb 26, 2021

/test pull-tekton-triggers-integration-tests

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Feb 26, 2021

/test pull-tekton-triggers-integration-tests

@khrm
Copy link
Contributor Author

khrm commented Feb 26, 2021

@dibyom I can't recreate locally. Here also it passed when I reran.

@dibyom
Copy link
Member

dibyom commented Mar 3, 2021

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@tekton-robot tekton-robot merged commit f90ab96 into tektoncd:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventListener return a 2xx status on failure
3 participants