Add support for custom object to triggers eventlistener #958

savitaashture · 2021-02-17T09:17:11Z

Changes

Introduced new field customResource to support Knative Service for EventListener as part of TEP0008
address Accept 0 as a valid value for EventListener replicas #925, Use Knative to create an EventListener Pod #571
Added additional printer column to support Knative status condition
later this can be addressed as part of Status Conditions for EventListener #932
Added doc, example
Added Unit test
Skipped adding securityContext because Knative serving masks securityContext under feature gate

Pending:

Secure connection for Custom Resource
Code Refactoring so that common things can be re used

Will work on subsequent PR for pending things

/cc @dibyom

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Introduced new field customResource to support Knative Service for EventListener

apiVersion: triggers.tekton.dev/v1alpha1
kind: EventListener
metadata:
  name: github-listener-interceptor-customresource
spec:
  ...
  resources:
    customResource:
      apiVersion: serving.knative.dev/v1
      kind: Service
      metadata:
      spec:
        template:
          spec:
            serviceAccountName: tekton-triggers-example-sa
            containers:
            - resources:
                requests:
                  memory: "64Mi"
                  cpu: "250m"
                limits:
                  memory: "128Mi"
                  cpu: "500m"

tekton-robot · 2021-02-17T09:19:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	68.0%	-5.9
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	95.4%	-2.0
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	39.4%	-40.9

tekton-robot · 2021-02-18T11:44:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	39.4%	-40.9

tekton-robot · 2021-02-18T12:09:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	39.6%	-40.7

tekton-robot · 2021-02-18T12:20:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	39.6%	-40.7

tekton-robot · 2021-02-18T12:34:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	39.8%	-40.6

tekton-robot · 2021-02-18T17:19:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	50.3%	-30.0
test/controller.go	73.1%	65.8%	-7.3

tekton-robot · 2021-02-18T17:32:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	50.3%	-30.0
test/controller.go	73.1%	72.7%	-0.5

tekton-robot · 2021-02-19T11:57:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	74.7%	-5.7
test/controller.go	73.1%	72.5%	-0.7

tekton-robot · 2021-02-19T13:20:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	56.3%	-24.0
test/controller.go	73.1%	72.5%	-0.7

tekton-robot · 2021-02-19T19:37:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	56.4%	-23.9
test/controller.go	73.1%	72.5%	-0.7

tekton-robot · 2021-02-19T19:55:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	74.6%	-5.7
test/controller.go	73.1%	72.5%	-0.7

tekton-robot · 2021-02-19T20:08:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	74.6%	-5.7
test/controller.go	73.1%	72.5%	-0.7

dibyom · 2021-02-25T20:02:39Z

Still 2% reduced as there are some scenario which is difficult to cover like unmarshal and status related code(Because WithPod don't have status)

Thanks I think that's ok for now.

dibyom

Thanks! almost there. Couple of minor comments.
Also: @sergetron do you want to review the docs for this PR?

pkg/dynamic/helpers.go

pkg/reconciler/v1alpha1/eventlistener/eventlistener_test.go

tekton-robot · 2021-02-26T05:08:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/dynamic/custom_reconcile.go	Do not exist	76.6%
pkg/dynamic/dynamic.go	Do not exist	0.0%
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	78.0%	-2.4
test/controller.go	73.1%	72.5%	-0.7

examples/custom-resource/README.md

tualeron · 2021-02-26T14:16:10Z

examples/custom-resource/README.md

+   In [`HMAC`](https://www.freeformatter.com/hmac-generator.html) `string` is the *body payload ex:* `{"action": "opened", "pull_request":{"head":{"sha": "28911bbb5a3e2ea034daf1f6be0a822d50e31e73"}},"repository":{"clone_url": "https://github.com/tektoncd/triggers.git"}}`
+   and `secretKey` is the *given secretToken ex:* `1234567`.
+
+1. You should see a new TaskRun that got created:


Same comment as above about "should".

As TriggerTemplate of EL explicitly creates TaskRun so i believe "should" suites here

In that case, "You will see the newly created TaskRun" is more appropriate.

modified
Thank you 👍

examples/custom-resource/README.md

docs/eventlisteners.md

tekton-robot · 2021-02-27T03:51:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/dynamic/custom_reconcile.go	Do not exist	76.6%
pkg/dynamic/dynamic.go	Do not exist	0.0%
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	78.0%	-2.4
test/controller.go	73.1%	72.5%	-0.7

savitaashture · 2021-03-01T18:44:33Z

@dibyom @sergetron addressed all the review comments

Thank you 🙏

dibyom · 2021-03-01T19:14:22Z

Thanks, could you squash up the commits?

tekton-robot · 2021-03-02T03:29:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_types.go	73.9%	76.0%	2.1
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.4%	97.7%	0.3
pkg/dynamic/custom_reconcile.go	Do not exist	76.6%
pkg/dynamic/dynamic.go	Do not exist	0.0%
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	80.3%	78.0%	-2.4
test/controller.go	73.1%	72.5%	-0.7

savitaashture · 2021-03-02T03:32:28Z

Thanks, could you squash up the commits?

Done 👍

dibyom

/lgtm

tekton-robot · 2021-03-02T23:59:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

savitaashture requested review from vdemeester and dibyom February 17, 2021 09:17

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 17, 2021

tekton-robot requested a review from dlorenc February 17, 2021 09:17

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 17, 2021

savitaashture force-pushed the customeObjectSupport branch from 518a884 to 5c3f8b8 Compare February 18, 2021 11:43

savitaashture force-pushed the customeObjectSupport branch from 5c3f8b8 to e99757e Compare February 18, 2021 12:07

savitaashture force-pushed the customeObjectSupport branch from e99757e to 6395d74 Compare February 18, 2021 12:18

savitaashture force-pushed the customeObjectSupport branch from 6395d74 to 12241f6 Compare February 18, 2021 12:33

savitaashture force-pushed the customeObjectSupport branch from 12241f6 to e1d7ee0 Compare February 18, 2021 17:17

savitaashture force-pushed the customeObjectSupport branch from e1d7ee0 to 6100c61 Compare February 18, 2021 17:31

savitaashture force-pushed the customeObjectSupport branch from 6100c61 to ced5e0f Compare February 19, 2021 11:56

savitaashture force-pushed the customeObjectSupport branch from ced5e0f to c353193 Compare February 19, 2021 13:19

savitaashture force-pushed the customeObjectSupport branch from c353193 to 8f82eac Compare February 19, 2021 19:35

savitaashture force-pushed the customeObjectSupport branch from 8f82eac to 0a06f65 Compare February 19, 2021 19:54

savitaashture force-pushed the customeObjectSupport branch from 0a06f65 to fdc1ebc Compare February 19, 2021 20:07

savitaashture force-pushed the customeObjectSupport branch from fdc1ebc to 0f90d52 Compare February 19, 2021 20:12

tektoncd deleted a comment from tekton-robot Feb 25, 2021

dibyom reviewed Feb 25, 2021

View reviewed changes

pkg/dynamic/helpers.go Outdated Show resolved Hide resolved

pkg/reconciler/v1alpha1/eventlistener/eventlistener_test.go Outdated Show resolved Hide resolved

tualeron reviewed Feb 26, 2021

View reviewed changes

examples/custom-resource/README.md Outdated Show resolved Hide resolved

tualeron reviewed Feb 26, 2021

View reviewed changes

examples/custom-resource/README.md Outdated Show resolved Hide resolved

tualeron reviewed Feb 26, 2021

View reviewed changes

docs/eventlisteners.md Outdated Show resolved Hide resolved

tualeron reviewed Feb 26, 2021

View reviewed changes

docs/eventlisteners.md Outdated Show resolved Hide resolved

tualeron reviewed Feb 26, 2021

View reviewed changes

docs/eventlisteners.md Outdated Show resolved Hide resolved

savitaashture force-pushed the customeObjectSupport branch from 17c04c3 to 8549250 Compare February 27, 2021 03:50

tektoncd deleted a comment from tekton-robot Feb 27, 2021

Add support for custom object to triggers eventlistener

39fb9d7

savitaashture force-pushed the customeObjectSupport branch from 8549250 to 39fb9d7 Compare March 2, 2021 03:28

dibyom approved these changes Mar 2, 2021

View reviewed changes

tekton-robot assigned dibyom Mar 2, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021

tekton-robot merged commit f84479a into tektoncd:master Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for custom object to triggers eventlistener #958

Add support for custom object to triggers eventlistener #958

savitaashture commented Feb 17, 2021 •

edited by dibyom

Loading

tekton-robot commented Feb 17, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

dibyom commented Feb 25, 2021

dibyom left a comment

tekton-robot commented Feb 26, 2021

tualeron Feb 26, 2021

savitaashture Feb 26, 2021

tualeron Feb 26, 2021

savitaashture Feb 27, 2021

tekton-robot commented Feb 27, 2021

savitaashture commented Mar 1, 2021

dibyom commented Mar 1, 2021

tekton-robot commented Mar 2, 2021

savitaashture commented Mar 2, 2021

dibyom left a comment

tekton-robot commented Mar 2, 2021

Add support for custom object to triggers eventlistener #958

Add support for custom object to triggers eventlistener #958

Conversation

savitaashture commented Feb 17, 2021 • edited by dibyom Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Feb 17, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 18, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

tekton-robot commented Feb 19, 2021

dibyom commented Feb 25, 2021

dibyom left a comment

Choose a reason for hiding this comment

tekton-robot commented Feb 26, 2021

tualeron Feb 26, 2021

Choose a reason for hiding this comment

savitaashture Feb 26, 2021

Choose a reason for hiding this comment

tualeron Feb 26, 2021

Choose a reason for hiding this comment

savitaashture Feb 27, 2021

Choose a reason for hiding this comment

tekton-robot commented Feb 27, 2021

savitaashture commented Mar 1, 2021

dibyom commented Mar 1, 2021

tekton-robot commented Mar 2, 2021

savitaashture commented Mar 2, 2021

dibyom left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 2, 2021

savitaashture commented Feb 17, 2021 •

edited by dibyom

Loading