Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing namespace to core-interceptors role #914

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jan 19, 2021

Changes

Add missing namespace to core-interceptors role

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@dibyom dibyom added the kind/bug Categorizes issue or PR as related to a bug. label Jan 19, 2021
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 19, 2021
@tekton-robot tekton-robot requested review from khrm and wlynch January 19, 2021 21:08
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2021
@dibyom
Copy link
Member Author

dibyom commented Jan 19, 2021

/cc @savitaashture might want to cherry-pick this to release-v0.11.x as well

Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@tekton-robot tekton-robot merged commit 576e784 into master Jan 19, 2021
@dibyom dibyom deleted the dibyom-patch-1 branch March 15, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants