Remove the template.Name field

[MarcelMue]

Changes

Simple PR which removes the already deprecated field.

Closes: #791

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

action required: The Template.Name field has been removed from the Trigger Spec. Please use Template.Ref instead.

[tekton-robot]

Hi @MarcelMue. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MarcelMue]

I did a quick skim of the docs but couldn't find anything referencing this name field. I could have very well missed something, so please double check if docs changes are necessary.

[dibyom]

/ok-to-test

[dibyom]

I did a quick skim of the docs but couldn't find anything referencing this name field. I could have very well missed something, so please double check if docs changes are necessary.

The field was deprecated a while back so we might have removed it from the docs. I'll take a look.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go	94.5%	94.2%	-0.3
pkg/template/resource.go	98.3%	100.0%	1.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go	94.5%	94.2%	-0.3
pkg/template/resource.go	98.3%	100.0%	1.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_validation.go	94.5%	94.2%	-0.3
pkg/template/resource.go	98.3%	100.0%	1.7

[dibyom]

Nice. Thanks!

One small thing: Can we update the release note to contain an action-required e.g.

action required: The Template.Name field has been removed from the Trigger Spec. Please use Template.Ref instead.

/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MarcelMue]

Nice. Thanks!

One small thing: Can we update the release note to contain an action-required e.g.

action required: The Template.Name field has been removed from the Trigger Spec. Please use Template.Ref instead.

/approve
/lgtm

Should be done - I guess it's still okay with an already merged PR.

[cameronbraid]

How do I workaround this ?

❯ kubectl  delete eventlistener gitea-backup
Error from server (BadRequest): admission webhook "validation.webhook.triggers.tekton.dev" denied the request: decoding request failed: cannot decode incoming old object: json: unknown field "name"