Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tekton eventlistener portname owing to istio naming conventions #880

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Update tekton eventlistener portname owing to istio naming conventions #880

merged 1 commit into from
Jan 6, 2021

Conversation

sravankumar777
Copy link
Contributor

@sravankumar777 sravankumar777 commented Dec 24, 2020 •
edited by dibyom
Loading

https://istio.io/docs/ops/deployment/requirements/

Changes

we should follow service port naming convention as stated here -> https://istio.io/docs/setup/kubernetes/additional-setup/requirements/
Update new latest release for tektoncd/trigger v0.10.2. Creation of underlying eventlistener svc gives error about service portname as per istio naming conventions.

Ports in your service are missing name in the format <protocol>[-<suffix>]. Supported protocols - istio.io/docs/setup/kubernetes/spec-requirements : Operation cannot be fulfilled on deployments.apps "el-valid-eventlistener": the object has been modified; please apply your changes to the latest version and try again

Release Note

Event listener port is now called `http-listener` instead of `listener`.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 24, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 24, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 24, 2020
@tekton-robot
Copy link

Hi @sravankumar777. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 24, 2020
@dibyom
Copy link
Member

dibyom commented Dec 28, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2020
@dibyom
Copy link
Member

dibyom commented Dec 28, 2020

LGTM but could you please sign the CLA @sravankumar777 ? Thanks!

@sravankumar777
Copy link
Contributor Author

LGTM but could you please sign the CLA @sravankumar777 ? Thanks!

@dibyom, i see this CLA is bit different.
Anything changed?

@sravankumar777
Copy link
Contributor Author

/retest

@MarcelMue
Copy link
Member

I am a bit confused here. This exact change was already done in a previous commit:
9dc4a4e
And then reverted later on again:
e1e7d18

I can not find a reference why @savitaashture decided to change it back.

@sravankumar777
Copy link
Contributor Author

@MarcelMue, for the recent change.

And then reverted later on again:
e1e7d18

we were using tekton with istio as service mesh in our environments.
Earlier, this issue was obesrved. Recently, we have updated tektoncd/triggers to v0.8.0.
We encountered this issue at the same time and so made the changes as per this PR.

@dibyom
Copy link
Member

dibyom commented Dec 29, 2020

Hmmm good catch @MarcelMue I think it might have been inadvertent but I'll wait for @savitaashture to comment!

@savitaashture
Copy link
Contributor

savitaashture commented Jan 4, 2021 •
edited
Loading

Hmmm good catch @MarcelMue I think it might have been inadvertent but I'll wait for @savitaashture to comment!

As we have added TLS support for the triggers the port name http-listener create name confusion for https connection so renamed to listener instead of http-listener

But considering istio port requirement we can revert it back and we can add new constant for https port name

WDYT @dibyom @MarcelMue

@savitaashture savitaashture mentioned this pull request Jan 5, 2021
Merged
4 tasks
@savitaashture
Copy link
Contributor

/test pull-tekton-triggers-integration-tests

@dibyom
Copy link
Member

dibyom commented Jan 5, 2021

But considering istio port requirement we can revert it back and we can add new constant for https port name

So, we'd check if TLS is enabled or not and if it is the name should be https-listener or else http-listener.
Do we have to do that in this PR itself? or can it be done in a follow up? @savitaashture ?

@MarcelMue
Copy link
Member

But considering istio port requirement we can revert it back and we can add new constant for https port name

So, we'd check if TLS is enabled or not and if it is the name should be https-listener or else http-listener.
Do we have to do that in this PR itself? or can it be done in a follow up? @savitaashture ?

I would be happy if this could be merged, I have already started to work on a follow up.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 6, 2021
@dibyom
Copy link
Member

dibyom commented Jan 6, 2021

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@tekton-robot tekton-robot merged commit 4363e89 into tektoncd:master Jan 6, 2021
@sravankumar777 sravankumar777 deleted the istio-naming-eventlistener-portname branch January 6, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sravankumar777 @tekton-robot @dibyom @MarcelMue @savitaashture