refactor: Do not use %w unless in fmt.Errorf #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using %w in some Zap logger calls. %w is only supported in `fmt.Errorf` calls and calling it in `fmt.Sprintf` will cause `go vet` to fail. Unfortunately, since the call to Sprintf happens inside the zap library, we do not trigger the go vet failure. Also, cleaned up some old usages of xerrors.Errorf to just fmt.Errorf. Fixes tektoncd#853 Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot
added
release-note
tekton-robot
added
the
size/S
khrm
approved these changes
Dec 4, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We were using %w in some Zap logger calls. %w is only supported in
fmt.Errorfcalls and calling it in
fmt.Sprintfwill causego vetto fail.Unfortunately, since the call to Sprintf happens inside the zap library, we do
not trigger the go vet failure.
Also, cleaned up some old usages of xerrors.Errorf to just fmt.Errorf.
Fixes #853
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes
/kind bug