Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with list results. #652

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix issue with list results. #652

merged 1 commit into from
Jul 6, 2020

Conversation

bigkevmcd
Copy link
Member

Changes

There was a bug in the handling of list results, where they weren't being marshaled correctly, resulting in an error.

This change identifies list results, and marshals them using the same method as the the tests in cel-go use.

This also bumps the version of cel to the latest 0.5.1.

This fixes: #651

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Fix bug marshaling list values from a CEL expression, which was causing panics.

@tekton-robot tekton-robot requested review from dibyom and dlorenc July 1, 2020 16:15
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 1, 2020
@bigkevmcd bigkevmcd force-pushed the handle-nil-responses branch from a3e97f5 to 592cda6 Compare July 1, 2020 16:21
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 88.3% 87.9% -0.5

@bigkevmcd bigkevmcd force-pushed the handle-nil-responses branch from 592cda6 to 75a02e0 Compare July 1, 2020 17:16
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 88.3% 87.9% -0.5

@bigkevmcd bigkevmcd force-pushed the handle-nil-responses branch from 75a02e0 to 63c010e Compare July 1, 2020 18:12
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 88.3% 87.9% -0.5

@bigkevmcd
Copy link
Member Author

/test tekton-triggers-unit-tests

@bigkevmcd bigkevmcd force-pushed the handle-nil-responses branch from 63c010e to c2d07f1 Compare July 1, 2020 20:18
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 88.3% 87.9% -0.5

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 88.3% 87.9% -0.5

@bigkevmcd
Fix issue with list results.
758015c 
There was a bug in the handling of list results, where they weren't being marshaled correctly, resulting in an error.

This change identifies list results, and marshals them accordingly.

This also bumps the version of cel to the latest 0.5.1
@bigkevmcd bigkevmcd force-pushed the handle-nil-responses branch from f704e71 to 758015c Compare July 2, 2020 08:21
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/cel.go 88.3% 87.9% -0.5

dibyom
dibyom approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bigkevmcd sounds like we should do a v0.6.1 for this since it is causing panics?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@tekton-robot tekton-robot merged commit 60f2842 into tektoncd:master Jul 6, 2020
@dibyom dibyom mentioned this pull request Jul 7, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using map in CEL panics the eventlistener
3 participants
@bigkevmcd @tekton-robot @dibyom