Add Support for Embedding TriggerBindingSpec in EL

[khrm]

Changes

Fixes #371

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

-  Support Embedding in EventListenerSpec
   TriggerBindingSpec can be added to EventListener Trigger.

-  Add Ref for TriggerBinding  in EventListenerSpec Trigger
   In addition to name, Ref also need to be specified. 
   At present, if ref isn't given and spec is also not there, name is considered as Ref. This behaviour will be deprecated in future releases. 

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Khurram Baig (d1d9784)

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/builder/eventlistener.go	92.2%	88.2%	-4.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/builder/eventlistener.go	92.2%	88.2%	-4.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
pkg/template/resource.go	100.0%	98.0%	-2.0
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
pkg/template/resource.go	100.0%	98.0%	-2.0
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
pkg/template/resource.go	100.0%	98.0%	-2.0
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
pkg/template/resource.go	100.0%	98.0%	-2.0
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
pkg/template/resource.go	100.0%	98.0%	-2.0
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	79.3%	-13.3
pkg/template/resource.go	100.0%	98.0%	-2.0
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	93.1%	0.5
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	93.1%	0.5
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	93.1%	0.5
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	93.1%	0.5
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	93.1%	0.5
test/builder/eventlistener.go	92.2%	92.6%	0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	93.1%	0.5
test/builder/eventlistener.go	92.2%	92.6%	0.5

[khrm]

@dibyom
I have kept name as an identifier to be used within EL irrespective of whether we have embedded or ref bindings. Atm, there doesn't seems to be a need for it but I can that we need to differentiate on how a param is coming from like here: #508
So we might need to do: tt.bindingname.param

[dibyom]

I have kept name as an identifier to be used within EL irrespective of whether we have embedded or ref bindings. Atm, there doesn't seems to be a need for it but I can that we need to differentiate on how a param is coming from like here: #508
So we might need to do: tt.bindingname.param

That's definitely a valid scenario though I'm not sure if we'd want to couple bindings within the template. At the moment though, keeping both name and ref seems confusing. Can we remove them from the examples at least? (we can keep/support the field but let's document and use ref as the default?). Should be simple enough to add back name if we need to later.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	92.9%	0.3
test/builder/eventlistener.go	92.2%	92.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	92.9%	0.3
test/builder/eventlistener.go	92.2%	92.8%	0.6

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go	100.0%	91.7%	-8.3
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.6%	92.9%	0.3
test/builder/eventlistener.go	92.2%	92.8%	0.6

[dibyom]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

/lgtm