Use static selector labels for EL svc/deployments #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/S
Previously, if a user added an extra label, we'd propagate that to the deployment and services. However, in addition, we'd also update the selector fields in both deployments and services to use this additional label. This is unnecessary since the static set of default labels that we add on each resource is enough to match and do not need to be updated throughout the lifecycle of the resources. Fixes tektoncd#463 Co-Authored-By: Vincent Tereso <[email protected]> Signed-off-by: Dibyo Mukherjee <[email protected]>
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
tekton-robot
removed
the
do-not-merge/work-in-progress
ncskier
approved these changes
Apr 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncskier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user added an extra label, we'd propagate that to the
deployment and services. However, in addition, we'd also update the selector
fields in both deployments and services to use this additional label. This is
unnecessary since the static set of default labels that we add on each resource
is enough to match and do not need to be updated throughout the lifecycle of
the resources.
Fixes #463
This PR replaces #510. Changes are:
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.