Add omitempty tag to Status field

[chetan-rns]

Add omitempty tags to status field of event-listeners, templates, bindings and cluster bindings.
Adding omitempty tags would allow omitting the status field if they have an empty value.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[tekton-robot]

Hi @chetan-rns. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chetan-rns]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[dibyom]

/ok-to-test

[chetan-rns]

/retest

[dibyom]

Hmm, do we even need Status for TriggerBinding and TriggerTemplate? I don't think we are using it at all.
So, we can just remove Status like some of the Pipeline types: https://github.com/tektoncd/pipeline/blob/master/pkg/apis/pipeline/v1beta1/task_types.go#L25

@ncskier

[ncskier]

Yeah, I don't think we're using status... nor do I think it makes sense for the TriggerBindings or TriggerTemplates to have a status 👍

[vdemeester]

beware of removing it now though 👼 it might break users (see https://github.com/tektoncd/pipeline/blob/master/pkg/apis/pipeline/v1alpha1/pipeline_types.go#L72-L76 – we had to keep it for… not breaking user 😝 )

[dibyom]

Ahh good catch...though the 0.4 release is already a breaking change due to the API groups changing...so this might be the time to do it if we ever do this!

[chetan-rns]

@dibyom So are we keeping the status field for bindings and templates? If not I can push the patch to remove status in the same PR

[dibyom]

Actually let's keep them with the omitempty for now. I think omitempty should fix @bigkevmcd 's issues with ArgoCD as well (if it doesn't please bring it up and we'll look at removing the status in 0.5 then!)

[bigkevmcd]

This would be really nice to have, it causes issues for ArgoCD when it's synchronising resources.

[dibyom]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment