Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change api version #502

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Change api version #502

merged 1 commit into from
Mar 26, 2020

Conversation

akihikokuroda
Copy link
Member

@akihikokuroda akihikokuroda commented Mar 25, 2020

Changes

This is the step 1 of #499
Change the API version of

  1. docs/create-ingress.yaml
  2. docs/create-webhook.yaml
    to v1beta1

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2020
@akihikokuroda
Copy link
Member Author

/uncc @iancoffey
/cc @dibyom

@tekton-robot tekton-robot requested review from dibyom and removed request for iancoffey March 25, 2020 20:00
Copy link
Member

@ncskier ncskier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With v1beta1, $(inputs.params. becomes $(params.. So, I think you'll have to update that in a few spots.

@akihikokuroda
Copy link
Member Author

Thanks for review. I'll fix them.

@ncskier
Copy link
Member

ncskier commented Mar 26, 2020

Thanks for the updates
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@tekton-robot tekton-robot merged commit 0fc59e0 into tektoncd:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants