Support JSON double values being reencoded in the CEL interceptor #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
bigkevmcd
force-pushed
the
fix-cel-increments
branch
from
d7a37ea to
f3a2bf7
Compare
|
I had a look at using a |
bigkevmcd
force-pushed
the
fix-cel-increments
branch
from
f3a2bf7 to
03a2c9a
Compare
bigkevmcd
force-pushed
the
fix-cel-increments
branch
from
03a2c9a to
91892d5
Compare
tekton-robot
added
size/L
bigkevmcd
force-pushed
the
fix-cel-increments
branch
from
91892d5 to
bd4c958
Compare
bigkevmcd
changed the title
bigkevmcd
force-pushed
the
fix-cel-increments
branch
from
bd4c958 to
708ffe2
Compare
When the JSON value 2 is decoded, it is a Double, so arithmetic on it returns doubles. It can be cast into an integer value which make it slightly easier to read. With further illustrative tests and documentation.
bigkevmcd
force-pushed
the
fix-cel-increments
branch
from
708ffe2 to
30a5eb1
Compare
dibyom
approved these changes
Mar 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, khrm, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
nikhil-thomas
added a commit
to nikhil-thomas/triggers
that referenced
this pull request
Jul 5, 2021
Add a check for an existing sync PR in the midstream repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the JSON value 2 is decoded, it is a Double, so arithmetic on it returns doubles.
This ensures that the double value is correctly reencoded for JSON.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes