Fix bug running multiple triggers #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tektoncd#387 This PR fixes a pointer bug where an EventListener with `n` triggers would have the last trigger execute `n` times instead of all `n` triggers executing once. This PR also updates the TestHandleEvent function to test multiple triggers. In the future, it might be worth refactoring the TestHandleEvent function into a testing table, so we can increase our test coverage.
tekton-robot
added
the
size/L
dibyom
approved these changes
Jan 27, 2020
| @@ -131,8 +146,11 @@ func TestHandleEvent(t *testing.T) { | |||
| if _, err := triggersClient.TektonV1alpha1().TriggerTemplates(namespace).Create(tt); err != nil { | |||
| t.Fatalf("Error creating TriggerTemplate: %s", err) | |||
| } | |||
| if _, err := triggersClient.TektonV1alpha1().TriggerBindings(namespace).Create(tb); err != nil { | |||
| t.Fatalf("Error creating TriggerBinding: %s", err) | |||
| // for _, tb := range []*triggersv1.TriggerBinding{tb, tb2, tb3} { | |||
| }, | ||
| }, | ||
| } | ||
| // var wantResources []pipelinev1.PipelineResource |
tekton-robot
added
the
approved
wlynch
approved these changes
Jan 27, 2020
| }, | ||
| }, | ||
| } | ||
| // var wantResources []pipelinev1.PipelineResource |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
|
Sorry, I forgot to clean up those comments. I created a PR to clean it up here: #389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #387
This PR fixes a pointer bug where an EventListener with
ntriggerswould have the last trigger execute
ntimes instead of allntriggers executing once.
This PR also updates the TestHandleEvent function to test multiple
triggers. In the future, it might be worth refactoring the
TestHandleEvent function into a testing table, so we can increase our
test coverage.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.